Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code update for HR4_roughness, background diffusivity and shallow convection #119

Merged
merged 56 commits into from
Jan 29, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
c18c6d4
CCPP scheme simulator.
Jan 30, 2023
f9abb73
Fix file rename typo
Jan 30, 2023
ef0d369
Added MPI commands to ccpp_scheme_simulator
Jan 31, 2023
fd72b35
Work in progress...
Feb 3, 2023
ffd26ab
Some changes
Feb 6, 2023
112ac89
Some small cleanup
Feb 7, 2023
6a4c4b1
More OO changes. Will split into load_data and ccpp_scheme components…
Feb 9, 2023
be4cc2e
More OO changes
Feb 10, 2023
7001ef9
Split scheme into load and simulator components.
Feb 13, 2023
8bc8ec9
Small bug fix to nml
Feb 13, 2023
6db4af5
Remove dimension for tracer, handle tracers individualy, not with sta…
Feb 13, 2023
147cbac
Fixed bug in interpolation routine.
Feb 14, 2023
a296389
Moew changes
Feb 17, 2023
e49f1f6
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into ccpp…
Apr 5, 2023
a3933a5
CCPP scheme simulator
May 4, 2023
833b990
Merge branch 'ufs/dev-gf' into ufs-dev-PR64
grantfirl May 4, 2023
3ba2924
Merge branch 'main' into ufs-dev-PR64
grantfirl May 8, 2023
6e53907
Merge commit 'd474c2' into ufs-dev-PR26
grantfirl May 9, 2023
2515b27
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into HEAD
May 30, 2023
5d49f79
Reorganization of scheme simulator. Now stateless.
Jun 1, 2023
d8a5b1f
Merge pull request #1015 from grantfirl/ufs-dev-PR64
grantfirl Jun 13, 2023
6f12331
Merge branch 'main' into ufs-dev-PR26
grantfirl Jun 13, 2023
4d69108
fix bug in scm_sfc_flux_spec.F90
grantfirl Jun 14, 2023
6cfaad5
Merge branch 'update_HR2' into ufs-dev-PR65
grantfirl Jun 26, 2023
93e0c8d
Merge commit '81e3f5e36' into ufs-dev-PR71
grantfirl Jun 26, 2023
bc94a0f
Merge remote-tracking branch 'joe-fork/mynn_snowfix' into ufs-dev-PR71
grantfirl Jun 26, 2023
92c8a9e
Merge pull request #1016 from grantfirl/ufs-dev-PR26
grantfirl Jun 29, 2023
c5566ab
Merge branch 'main' into ufs-dev-PR65
grantfirl Jun 29, 2023
ce731f2
Merge branch 'main' into ufs-dev-PR71
grantfirl Jun 29, 2023
12d4fc2
Working as expected!
Jul 7, 2023
6ceffe3
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into HEAD
Jul 7, 2023
9b77c4e
Merge pull request #1020 from grantfirl/ufs-dev-PR65
grantfirl Jul 7, 2023
9465b6f
Housekeeping
Jul 11, 2023
c61a2a6
GNU bug found in SCM CI
Jul 13, 2023
8e5646e
Some cleanup.
Jul 18, 2023
7e8cd3a
Merge branch 'main' into ufs-dev-PR71
grantfirl Jul 19, 2023
e3c00d3
Renamed scheme simulator suite simulator
Jul 19, 2023
2d6d44c
Omission from previous commit
Jul 19, 2023
5ab1a5b
Add ability to use constant forcing data when one-dimensional data is…
Jul 19, 2023
07a25fe
Merge branch 'main' of https://github.com/NCAR/ccpp-physics into HEAD
Aug 1, 2023
215ba6d
Merge pull request #996 from dustinswales/ccpp_scheme_sim
dustinswales Aug 1, 2023
1e7542a
Merge branch 'main' into ufs-dev-PR71
grantfirl Aug 3, 2023
fa96015
Merge pull request #1021 from grantfirl/ufs-dev-PR71
grantfirl Aug 3, 2023
4e45989
Code update for HR4_roughness
Qingfu-Liu Oct 16, 2023
3debf89
Code update for HR4_roughness
Qingfu-Liu Oct 16, 2023
c2b1301
Code update for HR4_roughness
Qingfu-Liu Oct 16, 2023
2fc24ca
Merge remote-tracking branch 'upstream/ufs/dev' into HR4_roughness
Qingfu-Liu Nov 28, 2023
91da6a0
Merge https://github.com/Qingfu-Liu/ccpp-physics into HR4_roughness
Qingfu-Liu Nov 28, 2023
562377c
remove files from old version
Qingfu-Liu Nov 28, 2023
12cd9c6
update files satmedmfvdifq.F samfshalcnv.f sfc_diff.f
Qingfu-Liu Nov 28, 2023
225848c
Merge remote-tracking branch 'upstream/ufs/dev' into HR4_roughness
Qingfu-Liu Dec 1, 2023
d65507a
Fix CI 2
Qingfu-Liu Dec 14, 2023
fa9931a
Merge remote-tracking branch 'upstream/ufs/dev' into HR4_roughness
Qingfu-Liu Jan 10, 2024
26ecb3d
Merge remote-tracking branch 'upstream/ufs/dev' into HR4_roughness
Qingfu-Liu Jan 16, 2024
97e3b1c
update surface physics z0 from waves
Qingfu-Liu Jan 18, 2024
327fbaa
Merge remote-tracking branch 'upstream/ufs/dev' into HR4_roughness
Qingfu-Liu Jan 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reorganization of scheme simulator. Now stateless.
  • Loading branch information
dustinswales committed Jun 1, 2023
commit 5d49f7942f4863441cc2678844a7b744952c9006
745 changes: 266 additions & 479 deletions physics/GFS_ccpp_scheme_sim_pre.F90

Large diffs are not rendered by default.

158 changes: 1 addition & 157 deletions physics/GFS_ccpp_scheme_sim_pre.meta
Original file line number Diff line number Diff line change
Expand Up @@ -5,170 +5,14 @@

########################################################################
[ccpp-arg-table]
name = GFS_ccpp_scheme_sim_pre_init
name = GFS_ccpp_scheme_sim_pre_run
type = scheme
[mpirank]
standard_name = mpi_rank
long_name = MPI rank of current process
units = index
dimensions = ()
type = integer
intent = in
[mpiroot]
standard_name = mpi_root
long_name = MPI rank of master process
units = index
dimensions = ()
type = integer
intent = in
[mpicomm]
standard_name = mpi_communicator
long_name = MPI communicator
units = index
dimensions = ()
type = integer
intent = in
[prc_LWRAD_cfg]
standard_name = configuration_for_physics_process_in_CCPP_scheme_simulator_LWRAD
long_name = configuration for physics process in CCPP scheme simulator LWRAD
units = flag
dimensions = (3)
type = integer
intent = in
[prc_SWRAD_cfg]
standard_name = configuration_for_physics_process_in_CCPP_scheme_simulator_SWRAD
long_name = configuration for physics process in CCPP scheme simulator SWRAD
units = flag
dimensions = (3)
type = integer
intent = in
[prc_PBL_cfg]
standard_name = configuration_for_physics_process_in_CCPP_scheme_simulator_PBL
long_name = configuration for physics process in CCPP scheme simulator PBL
units = flag
dimensions = (3)
type = integer
intent = in
[prc_GWD_cfg]
standard_name = configuration_for_physics_process_in_CCPP_scheme_simulator_GWD
long_name = configuration for physics process in CCPP scheme simulator GWD
units = flag
dimensions = (3)
type = integer
intent = in
[prc_SCNV_cfg]
standard_name = configuration_for_physics_process_in_CCPP_scheme_simulator_SCNV
long_name = configuration for physics process in CCPP scheme simulator SCNV
units = flag
dimensions = (3)
type = integer
intent = in
[prc_DCNV_cfg]
standard_name = configuration_for_physics_process_in_CCPP_scheme_simulator_DCNV
long_name = configuration for physics process in CCPP scheme simulator DCNV
units = flag
dimensions = (3)
type = integer
intent = in
[prc_cldMP_cfg]
standard_name = configuration_for_physics_process_in_CCPP_scheme_simulator_cldMP
long_name = configuration for physics process in CCPP scheme simulator cldMP
units = flag
dimensions = (3)
type = integer
intent = in
[nprg_active]
standard_name = number_of_prognostics_varaibles_in_CCPP_scheme_simulator
long_name = number of prognostic variables used in CCPP scheme simulator
units = count
dimensions = ()
type = integer
intent = in
[do_ccpp_scheme_sim]
standard_name = flag_for_ccpp_scheme_simulator
long_name = flag for ccpp scheme simulator
units = flag
dimensions = ()
type = logical
intent = in
[scheme_sim_data]
standard_name = filename_for_ccpp_scheme_simulator_data_file
long_name = filename for cccpp scheme simulator data file
units = none
dimensions = ()
type = character
kind = len=256
intent = in
[nprc_sim]
standard_name = number_of_physics_process_in_CCPP_scheme_simulator
long_name = number of physics process in CCPP scheme simulator
units = count
dimensions = ()
type = integer
intent = in
[active_name]
standard_name = name_of_active_physics_schemes_in_CCPP_scheme_simulator
long_name = name of active physics schemes in CCPP scheme simulator
units =
dimensions = (number_of_active_physics_process_in_CCPP_scheme_simulator)
type = character
kind = len=16
intent = inout
[iactive_scheme]
standard_name = index_of_active_physics_schemes_in_CCPP_scheme_simulator
long_name = index of active physics schemes in CCPP scheme simulator
units = count
dimensions = (number_of_active_physics_process_in_CCPP_scheme_simulator)
type = integer
intent = inout
[active_time_split_process]
standard_name = flag_to_indicate_process_type_in_CCPP_scheme_simulator
long_name = flag to indicate if active physics schemes are time-split process
units = flag
dimensions = (number_of_active_physics_process_in_CCPP_scheme_simulator)
type = logical
intent = inout
[physics_process]
standard_name = physics_process_type_for_CCPP_scheme_simulator
long_name = physics process type for CCPP scheme simulator
units = mixed
dimensions = (number_of_physics_process_in_CCPP_scheme_simulator)
type = base_physics_process
intent = inout
[errmsg]
standard_name = ccpp_error_message
long_name = error message for error handling in CCPP
units = none
dimensions = ()
type = character
kind = len=*
intent = out
[errflg]
standard_name = ccpp_error_code
long_name = error code for error handling in CCPP
units = 1
dimensions = ()
type = integer
intent = out

########################################################################
[ccpp-arg-table]
name = GFS_ccpp_scheme_sim_pre_run
type = scheme
[iactive_scheme_inloop]
standard_name = count_for_active_scheme_in_CCPP_scheme_simulator
long_name = count for active physics scheme in CCPP scheme simulator
units = count
dimensions = ()
type = integer
intent = in
[active_name]
standard_name = name_of_active_physics_schemes_in_CCPP_scheme_simulator
long_name = name of active physics schemes in CCPP scheme simulator
units =
dimensions = (number_of_active_physics_process_in_CCPP_scheme_simulator)
type = character
kind = len=16
intent = in
[dtend]
standard_name = cumulative_change_of_state_variables
Expand Down
26 changes: 8 additions & 18 deletions physics/ccpp_scheme_simulator.F90
Original file line number Diff line number Diff line change
Expand Up @@ -22,26 +22,21 @@ module ccpp_scheme_simulator
!! \htmlinclude ccpp_scheme_simulator_run.html
!!
subroutine ccpp_scheme_simulator_run(do_ccpp_scheme_sim, kdt, nCol, nLay, dtp, jdat, &
nactive_proc, proc_start, proc_end, active_name, iactive_scheme, physics_process, &
active_time_split_process, iactive_scheme_inloop, in_pre_active, in_post_active, &
tgrs, ugrs, vgrs, qgrs, active_phys_tend, gt0, gu0, gv0, gq0, dtdq_pbl, dtdq_mp, &
errmsg, errflg)
proc_start, proc_end, physics_process, in_pre_active, in_post_active, tgrs, ugrs, &
vgrs, qgrs, active_phys_tend, gt0, gu0, gv0, gq0, errmsg, errflg)

! Inputs
logical, intent(in) :: do_ccpp_scheme_sim, active_time_split_process(:)
integer, intent(in) :: kdt, nCol, nLay, nactive_proc, jdat(8), &
iactive_scheme(:)
logical, intent(in) :: do_ccpp_scheme_sim
integer, intent(in) :: kdt, nCol, nLay, jdat(8)
real(kind_phys), intent(in) :: dtp, tgrs(:,:), ugrs(:,:), vgrs(:,:), qgrs(:,:,:), &
active_phys_tend(:,:,:)
character(len=16), intent(in) :: active_name(:)

! Outputs
type(base_physics_process),intent(inout) :: physics_process(:)
real(kind_phys), intent(inout) :: gt0(:,:), gu0(:,:), gv0(:,:), gq0(:,:), &
dtdq_pbl(:,:), dtdq_mp(:,:)
real(kind_phys), intent(inout) :: gt0(:,:), gu0(:,:), gv0(:,:), gq0(:,:)
character(len=*),intent(out) :: errmsg
integer, intent(out) :: errflg
integer, intent(inout) :: proc_start, proc_end, iactive_scheme_inloop
integer, intent(inout) :: proc_start, proc_end
logical, intent(inout) :: in_pre_active, in_post_active

! Locals
Expand Down Expand Up @@ -77,10 +72,10 @@ subroutine ccpp_scheme_simulator_run(do_ccpp_scheme_sim, kdt, nCol, nLay, dtp, j
!
if (in_pre_active) then
proc_start = 1
proc_end = max(1,iactive_scheme(iactive_scheme_inloop)-1)
proc_end = max(1,physics_process(1)%iactive_scheme-1)
endif
if (in_post_active) then
proc_start = iactive_scheme(iactive_scheme_inloop)
proc_start = physics_process(1)%iactive_scheme
proc_end = size(physics_process)
endif

Expand Down Expand Up @@ -179,11 +174,6 @@ subroutine ccpp_scheme_simulator_run(do_ccpp_scheme_sim, kdt, nCol, nLay, dtp, j
if (size(physics_process)+1 == iprc) then
in_pre_active = .true.
in_post_active = .false.
iactive_scheme_inloop = 1
endif

if (iactive_scheme_inloop < nactive_proc) then
iactive_scheme_inloop = iactive_scheme_inloop + 1
endif

end subroutine ccpp_scheme_simulator_run
Expand Down
52 changes: 0 additions & 52 deletions physics/ccpp_scheme_simulator.meta
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,6 @@
dimensions = (8)
type = integer
intent = in
[nactive_proc]
standard_name = number_of_active_physics_process_in_CCPP_scheme_simulator
long_name = number of active physics process in CCPP scheme simulator
units = count
dimensions = ()
type = integer
intent = in
[proc_start]
standard_name = index_for_first_physics_process_in_CCPP_scheme_simulator
long_name = index for first physics process in CCPP scheme simulator
Expand All @@ -70,13 +63,6 @@
dimensions = ()
type = integer
intent = inout
[iactive_scheme_inloop]
standard_name = count_for_active_scheme_in_CCPP_scheme_simulator
long_name = count for active physics scheme in CCPP scheme simulator
units = count
dimensions = ()
type = integer
intent = inout
[in_pre_active]
standard_name = flag_to_indicate_location_in_physics_process_loop_before_active_scheme
long_name = flag to indicate location in physics process loop before active scheme
Expand All @@ -91,28 +77,6 @@
dimensions = ()
type = logical
intent = inout
[active_name]
standard_name = name_of_active_physics_schemes_in_CCPP_scheme_simulator
long_name = name of active physics schemes in CCPP scheme simulator
units =
dimensions = (number_of_active_physics_process_in_CCPP_scheme_simulator)
type = character
kind = len=16
intent = in
[iactive_scheme]
standard_name = index_of_active_physics_schemes_in_CCPP_scheme_simulator
long_name = index of active physics schemes in CCPP scheme simulator
units = count
dimensions = (number_of_active_physics_process_in_CCPP_scheme_simulator)
type = integer
intent = in
[active_time_split_process]
standard_name = flag_to_indicate_process_type_in_CCPP_scheme_simulator
long_name = flag to indicate if active physics schemes are time-split process
units = flag
dimensions = (number_of_active_physics_process_in_CCPP_scheme_simulator)
type = logical
intent = in
[tgrs]
standard_name = air_temperature
long_name = model layer mean temperature
Expand Down Expand Up @@ -185,22 +149,6 @@
type = real
kind = kind_phys
intent = inout
[dtdq_pbl]
standard_name = instantaneous_tendency_of_specific_humidity_due_to_PBL
long_name = instantaneous_tendency_of_specific_humidity_due_to_PBL
units = kg kg-1 s-1
dimensions = (horizontal_loop_extent,vertical_layer_dimension)
type = real
kind = kind_phys
intent = inout
[dtdq_mp]
standard_name = instantaneous_tendency_of_specific_humidity_due_to_microphysics
long_name = moisture tendency due to microphysics
units = kg kg-1 s-1
dimensions = (horizontal_loop_extent,vertical_layer_dimension)
type = real
kind = kind_phys
intent = inout
[physics_process]
standard_name = physics_process_type_for_CCPP_scheme_simulator
long_name = physics process type for CCPP scheme simulator
Expand Down
Loading