Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in example JSON file #1115

Closed
wants to merge 1 commit into from

Conversation

BaronVonPerko
Copy link

The example in the readme file fails due to an extra comma.

The example in the readme file fails due to an extra comma.
@codecov-io
Copy link

Codecov Report

Merging #1115 (8cb957a) into master (c7af74f) will increase coverage by 82.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1115       +/-   ##
===========================================
+ Coverage        0   82.09%   +82.09%     
===========================================
  Files           0      170      +170     
  Lines           0     2072     +2072     
  Branches        0      247      +247     
===========================================
+ Hits            0     1701     +1701     
- Misses          0      276      +276     
- Partials        0       95       +95     
Impacted Files Coverage Δ
...src/lib/slider/dynamic-primeng-slider.component.ts 100.00% <0.00%> (ø)
...heckbox/dynamic-ng-bootstrap-checkbox.component.ts 100.00% <0.00%> (ø)
...b/form-array/dynamic-ionic-form-array.component.ts 11.11% <0.00%> (ø)
...opdownlist/dynamic-kendo-dropdownlist.component.ts 100.00% <0.00%> (ø)
.../core/src/lib/model/select/dynamic-select.model.ts 80.00% <0.00%> (ø)
.../src/lib/service/dynamic-form-component.service.ts 72.41% <0.00%> (ø)
.../dynamic-basic-form-control-container.component.ts 95.83% <0.00%> (ø)
...c/lib/select/dynamic-bootstrap-select.component.ts 100.00% <0.00%> (ø)
...lib/calendar/dynamic-primeng-calendar.component.ts 72.72% <0.00%> (ø)
...dio-group/dynamic-primeng-radio-group.component.ts 100.00% <0.00%> (ø)
... and 160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7af74f...8cb957a. Read the comment docs.

@matheo
Copy link

matheo commented Apr 16, 2021

Hi @BaronVonPerko
Do you mind to share your experience with dynamic forms
in the discussions of a new library to implement advanced features?
https://dev.to/myndpm/a-new-approach-to-have-dynamic-forms-in-angular-5d11
Thanks in advance!

@udos86 udos86 closed this Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants