Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): support custom model json map fn injectionToken #1009

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat(core): support custom model json map fn injectionToken #1009

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69ea14a
feat(core): support custom model json map fn injectionToken
ronherolo Aug 17, 2019
1a9faf0
test(core): get layout from map fn
ronherolo Aug 17, 2019
ed78b24
fix(core): remove config map fn type from costructor
ronherolo Aug 17, 2019
84fd0d0
test(core): cover getCustomComponentModel method with test
ronherolo Aug 17, 2019
23ad525
test(core): import coverage in dynamicFormService
ronherolo Aug 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(core): get layout from map fn
  • Loading branch information
@ronherolo
ronherolo committed Aug 17, 2019
commit 1a9faf0ea426062072b1cf631c4d35b1ebf6ed9d
3 changes: 1 addition & 2 deletions projects/ng-dynamic-forms/core/src/lib/service/dynamic-form.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ describe("DynamicFormService test suite", () => {
readonly type = DYNAMIC_FORM_CONTROL_TYPE_CUSTOM;
}

const dynamicFormControlModelConfigMapFn: DynamicFormControlModelConfigMapFn = (model, formService) => {
const layout = model.layout;
const dynamicFormControlModelConfigMapFn: DynamicFormControlModelConfigMapFn = (model, layout, formService) => {
switch (model.type) {
case DYNAMIC_FORM_CONTROL_TYPE_CUSTOM:
return new DynamicCustomModel(model, layout);
Expand Down