Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_gdc.py: Fix test_get_samples_clinical test #40

Merged
merged 1 commit into from
Jun 7, 2019
Merged

test_gdc.py: Fix test_get_samples_clinical test #40

merged 1 commit into from
Jun 7, 2019

Conversation

ayan-b
Copy link
Collaborator

@ayan-b ayan-b commented Jun 6, 2019

No description provided.

@ayan-b ayan-b mentioned this pull request Jun 6, 2019
Closed
yunhailuo
yunhailuo previously approved these changes Jun 7, 2019
View reviewed changes
Copy link
Collaborator

@yunhailuo yunhailuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in #34 , the test failed because GDC updated their data. It suggests that the test is not stable. The fix here changing just the uuid is not stable either.

@yunhailuo yunhailuo self-requested a review June 7, 2019 04:46
@yunhailuo yunhailuo dismissed their stale review June 7, 2019 04:46

Wrong submission. Should require changes

yunhailuo
yunhailuo requested changes Jun 7, 2019
View reviewed changes
Copy link
Collaborator

@yunhailuo yunhailuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in #34 , the test failed because GDC updated their data. It suggests that the test is not stable. The fix here changing just the uuid is not stable either.

@ayan-b
Copy link
Collaborator Author

ayan-b commented Jun 7, 2019

Understood, pushing a fix. 👍

yunhailuo
yunhailuo approved these changes Jun 7, 2019
View reviewed changes
tests/test_gdc.py Show resolved Hide resolved
@yunhailuo yunhailuo merged commit ff886fc into ucscXena:master Jun 7, 2019
@ayan-b ayan-b deleted the fix-clinical-test branch June 7, 2019 05:12
@ayan-b ayan-b restored the fix-clinical-test branch June 8, 2019 15:59
@ayan-b ayan-b deleted the fix-clinical-test branch June 8, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhailuo yunhailuo yunhailuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ayan-b @yunhailuo