Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up parser for gdc2xena #25

Closed
wants to merge 2 commits into from
Closed

Set up parser for gdc2xena #25

wants to merge 2 commits into from

Conversation

ayan-b
Copy link
Collaborator

@ayan-b ayan-b commented May 6, 2019 •
edited
Loading

Closes #16

Needs a rebase once #24 is merged.

@ayan-b ayan-b mentioned this pull request May 6, 2019
Merged
@yunhailuo
Copy link
Collaborator

Is this on top of #24 ? If so, let's work #24 out, then rebase this PR. da4c41f looks fine. But I'll take another look after #24 and rebase.

@ayan-b ayan-b mentioned this pull request May 13, 2019
Merged
@yunhailuo
Copy link
Collaborator

#24 merged. Please rebase as you want.

@ayan-b
Copy link
Collaborator Author

ayan-b commented May 13, 2019 •
edited
Loading

Rebased. This PR finally closes #16.
Ah, seems its wrongly rebased.

@ayan-b
Copy link
Collaborator Author

ayan-b commented May 13, 2019 •
edited
Loading

The code for this PR went with the last PR itself, and the reason being the last commit d9c5048 I added. Thus, I am closing this PR.

@ayan-b ayan-b closed this May 13, 2019
@ayan-b ayan-b deleted the gdc2xena branch May 13, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve CLI
2 participants
@ayan-b @yunhailuo