-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.0 rc.1 #133
Draft
expede
wants to merge
257
commits into
main
Choose a base branch
from
v1.0-rc.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that not all of them pass yet, and that the build tests are impossible to support, as currently defined, due to JSON canonicalization issues. Fixtures from: ucan-wg/conformance-tests#13
This also generally cleans up the trait bounds, and removes the unused Fact trait
Co-authored-by: Philipp Krüger <[email protected]>
Co-authored-by: Philipp Krüger <[email protected]>
… UCAN Co-authored-by: Philipp Krüger <[email protected]>
Co-authored-by: Philipp Krüger <[email protected]>
Signed-off-by: Philipp Krüger <[email protected]>
Also: Take `impl AsRef<str>` in some places instead of `String` (and standardize on specifying it as an `impl`-in-place).
* refactor: Make delegation::Store::get return Option * refactor: Make delegation::Store::insert take &self instead of &mut self * refactor: Make invocation::Store take &self instead of &mut self * refactor: Make `delegation::Agent` not take `&mut self` in methods * refactor: Make `Agent` take `DID` by value * refactor: Take `DID` by value in `delegation::Agent::new` * refactor: Change generic order in `delegation::Agent` and add defaults
Test delegation store
Wrap auto CID Insert error
…x-chain Remove unrestricted powerbox chain
This reverts commit c06e6de.
More bugfixes & some suggested changes
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
===========================================
- Coverage 62.12% 13.54% -48.58%
===========================================
Files 24 68 +44
Lines 895 5803 +4908
Branches 214 2762 +2548
===========================================
+ Hits 556 786 +230
- Misses 196 4428 +4232
- Partials 143 589 +446
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.