Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowTitle is the one which may have LTS in #264

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

CarlosNihelton
Copy link
Collaborator

At the eleventh hour we got this paramter wrong in the upgrade policy feature.

For example, a sample DistributionInfo.h from 22.04.1 contains the following:

    const std::wstring Name = L"Ubuntu-22.04";

    // The title bar for the console window while the distribution is installing.
    const std::wstring WindowTitle = L"Ubuntu 22.04.1 LTS";

The intended behavior cannot be achieved with DistributionInfo::Name, but with DistributionInfo::WindowTitle instead.

        if (starts_with(name, L"Ubuntu") && ends_with(name, L"LTS")) {
            return L"never";
        }

For example:
```cpp
    const std::wstring Name = L"Ubuntu-22.04";

    // The title bar for the console window while the distribution is installing.
    const std::wstring WindowTitle = L"Ubuntu 22.04.1 LTS";
```
@CarlosNihelton CarlosNihelton marked this pull request as ready for review August 8, 2022 21:18
Copy link
Contributor

@toktamis toktamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization concern is checked and Windows title will not be localized

@toktamis toktamis merged commit 7dc7473 into main Aug 9, 2022
@toktamis toktamis deleted the fix-upgrade-policy branch August 9, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants