Checks whether the rootfs has UDI or Subiquity snaps #249
Conversation
Let's place there those small bits that resemble std algorithms. They seem very useful to be tied to one namespace. Also, made them templates, to deal with char and wchar_t. Moves concat as well
Both ubuntu-desktop-installer and subiquity. For now only the first is relevant. Soon the second will be.
| // Common algorithms to be used everywhere in the launcher project with style resembling the std ones. | ||
|
|
||
| template <typename CharT> | ||
| bool starts_with(const std::basic_string_view<CharT> tested, const std::basic_string_view<CharT> start) |
There was a problem hiding this comment.
2 adjacent parameters of starts_with of similar type (const std::basic_string_view<CharT>) are easily swapped by mistake
There was a problem hiding this comment.
It is indeed somewhat bug prone, but those are the only parameters the function accept, I don't see other way to do it :D.
There was a problem hiding this comment.
👍
In the future maybe we should refactor a bit and put all algorithms tests in their own test suite.
Also, some functions around the codebase might be better here as well. Things like wide_string_to_utf8, or safe_execute as quick examples.
That I'd say is outside the scope of this PR, so approving.
I like the idea. |
Currently only checking for UDI is relevant. Soon Subiquity-only will be as well, which will break the possibility of rendering a GUI from inside Linux, since there will be no GUI there anymore.
Thus, this pull request modifies the function that checks whether the distro is GUI-enabled to check for the existence of the UDI snap.
Since I wanted to reuse your implementation of
starts|ends_withalgorithms, I created a new header to host them (plus some other bits with similar scope).