[CI] Attempts to avoid break when diff consists of one whitespace only #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ecee06
to
124a174
Compare
... diff consists of one whitespace only
124a174
to
8552fcc
Compare
DistroLauncher/ini_find_value.cpp
Outdated
Comment on lines
102
to
105
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Clang-format suggestion below:
Suggested change
There was a problem hiding this comment.
We had previous crashes due to code changes like that.
DistroLauncher/ini_find_value.cpp
Outdated
| } | ||
|
|
||
| return false; | ||
| return false; |
There was a problem hiding this comment.
Clang-format suggestion below:
Suggested change
| return false; | |
| return false; |
| @@ -90,7 +90,7 @@ namespace Oobe | |||
| } // namespace. | |||
|
|
|||
| SplashEnabledStrategy::SplashEnabledStrategy() : splashExePath{splashPath()} | |||
| { } | |||
| { } | |||
There was a problem hiding this comment.
Clang-format suggestion below:
Suggested change
| { } | |
| { | |
| } |
There was a problem hiding this comment.
This is exactly equal to the source change that caused the last crash.
EduardGomezEscandell
approved these changes
Jul 26, 2022
That's unique to Ubuntu WSL. I think this piece that generates comments from a diff has a very interesting potential, but for now it's only used here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we fail to follow the formatting convention due to whitespaces and new lines only. In such cases CI fails to generate GitHub PR comments with the following validation error message:
It seems that the
start_lineandlinefields of a comment object must not be the same otherwise, the invariantstart line must precede the end linewill not hold.This is somewhat an educated guess, because the comment object documentation is not very clear on that.
This PR aims to make sure that invariant holds by not including the
start_linefield when it's equal tolineand further manipulation of the diff hunk target line contents to ensure we always ends with a new line if not empty.Only commit e36ea7f is relevant code wise.
In order to demonstrate that this is behaving as expected, commits 8552fcc and 8c47a0c were created simulating the typical formatting errors that caused crashes before. The results are manifested in the github-actions-bot comments that can be seen below. The last commit just reverts those two.