Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables MSBuild to update and build the Flutter app if required #229

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

CarlosNihelton
Copy link
Collaborator

@CarlosNihelton CarlosNihelton commented Jul 18, 2022

Attempting to build the solution without having the Flutter splash subproject checked out and compiled in release mode produces a message almost impossible to correlate with the real problem in the build system.

This PR enables automatically updating and building the Flutter submodule as part of the appx build system. The task is skipped if the $(FlutterSplashRoot)\build\windows\runner\Release\ directory exists.

It of course will only work if Git and Flutter are in the user's PATH.

@CarlosNihelton CarlosNihelton marked this pull request as ready for review July 18, 2022 17:52
Copy link
Collaborator

@EduardGomezEscandell EduardGomezEscandell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Always nice to make building easier.

@CarlosNihelton CarlosNihelton merged commit d6da956 into main Jul 19, 2022
@CarlosNihelton CarlosNihelton deleted the auto-msbuild-flutter branch July 19, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants