This app rootdir #220
Merged
This app rootdir #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extracted function returns the directory where this app is installed into. It was very local to the splash enabled app strategy. Removing this bit will benefit the new strategy related to the OOBE on Windows. Also, the patch feature will likely need this piece of logic as well.
EduardGomezEscandell
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the splash executable (the slide show) is located inside the appx directory at the same level as the launcher. Soon we'll have the new OOBE located in the same directory, but a different filename. The patch feature being drafted in #217 will likely store files in a subdirectory as well. So, to avoid duplication, this PR extracts the logic to find this app root directory into it's own function, so we can append subdirectories and filenames as we wish.
The usage is illustrated in the
ApplicationStrategy.cppwhere we locate theubuntu_wsl_splash.exerelative to that path.