Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents running the build workflow on draft PRs #219

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

CarlosNihelton
Copy link
Collaborator

@CarlosNihelton CarlosNihelton commented Jul 11, 2022

That workflow is quite slow, due the need to download and package a real rootfs.
We need to figure out ways to make it faster, but in the meanwhile, let's skip it for draft PR's until they are marked as ready for review.

This workflow is quite slow.
We need to figure out ways to make it faster.
In the meanwhile, let's skip it for draft PR's
Until they are marked as ready for review.
@CarlosNihelton
Copy link
Collaborator Author

The screenshot shows it disabling the worflow:
image

@CarlosNihelton CarlosNihelton marked this pull request as ready for review July 11, 2022 20:31
@CarlosNihelton
Copy link
Collaborator Author

And now, after marking as ready for review:
image

Copy link
Collaborator

@EduardGomezEscandell EduardGomezEscandell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@CarlosNihelton CarlosNihelton merged commit 982e091 into main Jul 12, 2022
@CarlosNihelton CarlosNihelton deleted the avoid-slow-build-when-drafting branch July 12, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants