Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-return lambda warning #209

Merged
merged 4 commits into from
Jun 20, 2022
Merged

Fix no-return lambda warning #209

merged 4 commits into from
Jun 20, 2022

Conversation

EduardGomezEscandell
Copy link
Collaborator

There is a lambda that we know always returns a value, but the compiler is unaware of this.

This fix adds a sanity test to ensure it trully never happens (in debug mode), and tells the compiler so in Release mode.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Please check out carefully the isses found by clang-tidy in the new code ⚠️
⚠️ clang-format found formatting issues in the code submitted.:warning:
Make sure to run clang-format and update this pull request.
(1/1)

DistroLauncher/WSLInfo.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@EduardGomezEscandell EduardGomezEscandell merged commit fa3e676 into main Jun 20, 2022
@EduardGomezEscandell EduardGomezEscandell deleted the fix-lambda-warning branch June 20, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants