Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check around optional splash access #207

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Added check around optional splash access #207

merged 2 commits into from
Jun 17, 2022

Conversation

EduardGomezEscandell
Copy link
Collaborator

@EduardGomezEscandell EduardGomezEscandell commented Jun 16, 2022 •
edited
Loading

Motivation

When using a rootfs corresponding to Ubuntu 20.04 LTS, a std::bad_optional_access exception is thrown.

Changes

This is fixed by adding a check around it.

CarlosNihelton
CarlosNihelton approved these changes Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@CarlosNihelton CarlosNihelton merged commit 3c3cb37 into ubuntu:main Jun 17, 2022
@EduardGomezEscandell EduardGomezEscandell deleted the splash-accessing-empty-optional branch June 20, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosNihelton CarlosNihelton CarlosNihelton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EduardGomezEscandell @CarlosNihelton