cover request with Isbn13 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cover request now with Isbn13 if available
renspr
reviewed
Jan 26, 2023
app/views/searches/_record.html.slim
Outdated
| @@ -12,7 +12,7 @@ ruby: | |||
| div.align-self-start.text-center.text-muted.me-3(style="width: 55px; min-width: 55px; position: relative") | |||
| / Cover Image | |||
| div.fa-regular.fa-file.fa-3x.bg-light.w-100.p-2.pt-3.pb-3.rounded | |||
| - isbn = record.additional_identifiers.select{|i| i.type == :isbn}.first&.value&.gsub("-", "") | |||
| - isbn = record.additional_identifiers.select{|i| i.type == :isbn && i.value&.length >= 13}.first&.value&.gsub("-", "")&.delete(" ") | |||
There was a problem hiding this comment.
Der Fix ist soweit super. Da wir hier nun aber eine Logik hinterlegen in der Form "der Service versteht nur 13 stellige ISBN-Nummern", frage ich mich, ob wir diese Logik nicht lieber in den CoverImagesController verlegen, und anstatt die ISBN-Nummer als Parameter zu übergeben, lieber die recordId übergeben. Der CoverImagesController müsse dann nochmal den Record anhand der ID aus ElasticSearch laden und dann die erste 13 stellige ISBN extrahieren.
There was a problem hiding this comment.
Klingt gut.
Werde das mal so wie beschrieben angehen.
renspr
reviewed
Jan 26, 2023
renspr
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cover request now with Isbn13 if available
closes ubpb/issues#72