correct typing on EditableGeojsonLayerProps get* functions #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The typing of getLineWidth, getRadius, etc. doesn't reflect that they're passed isSelected and mode
igorDykhta
approved these changes
Jul 19, 2022
Akiyamka
reviewed
Dec 20, 2022
|
|
||
| getTentativeLineColor?: Color | ((feature, isSelected, mode) => Color); | ||
| getTentativeFillColor?: Color | ((feature, isSelected, mode) => Color); | ||
| getTentativeLineWidth?: number | ((f) => number); | ||
| getTentativeLineWidth?: number | ((feature, isSelected, mode) => number); |
There was a problem hiding this comment.
For me it looks like type was correct.
There how it used:
https://github.com/uber/nebula.gl/blob/master/modules/layers/src/layers/editable-geojson-layer.ts#L203
Am I missing something?
There was a problem hiding this comment.
You are correct. This one uses different accessor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typing of getLineWidth, getRadius, etc. doesn't reflect that they're passed isSelected and mode, like all the others