Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparing for release 3.6.3 #307

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Preparing for release 3.6.3 #307

merged 1 commit into from
Jan 21, 2020

Conversation

nrabinowitz
Copy link
Collaborator

Updates CHANGELOG and VERSION

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.256% when pulling 836d3cb on nrabinowitz:release-3.6.3 into ed5c4f2 on uber:master.

@nrabinowitz nrabinowitz merged commit 8e745ce into uber:master Jan 21, 2020
ajfriend
ajfriend reviewed Jan 21, 2020
View reviewed changes
CHANGELOG.md
@@ -6,6 +6,8 @@ The public API of this library consists of the functions declared in file
[h3api.h.in](./src/h3lib/include/h3api.h.in).

## [Unreleased]

## [3.6.3] - 2020-01-21
### Fixed
- `compact` detects and fails on cases with duplicated input indexes. (#299)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be explicit in saying it "detects some (but not all) cases with duplicated input indexes"?

Ideally, we'd also drop that into the function documentation.

mrdvt92 pushed a commit to mrdvt92/h3 that referenced this pull request Jun 19, 2022
Merge pull request uber#307 from nrabinowitz/release-3.6.3
1bfa3d4 
Preparing for release 3.6.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajfriend ajfriend ajfriend left review comments

@isaacbrodsky isaacbrodsky isaacbrodsky approved these changes

@dfellis dfellis dfellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nrabinowitz @coveralls @dfellis @ajfriend @isaacbrodsky