[RibCoroutineWorker] In asWorker(), keep scope alive until lifecycl…
#625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55eb7c9
to
bef916d
Compare
…e completion. This fixes Rx subscriptions using `autoDispose(CoroutineScope)` immediately terminating. In order to properly support `autoDispose(CoroutineScope)` subscriptions, we must keep the `CoroutineScope` received in `onStart` alive as long as the `WorkerScopeProvider` lifecycle. `autoDispose` does *not* create a children coroutine: instead it installs a completion handler. Hence, outer scope will not have children to wait for completion and will terminate immediately.
FranAguilera
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e completion.
This fixes Rx subscriptions using
autoDispose(CoroutineScope)immediately terminating.In order to properly support
autoDispose(CoroutineScope)subscriptions, we must keep theCoroutineScopereceived inonStartalive as long as theWorkerScopeProviderlifecycle.autoDisposedoes not create a child coroutine: instead it installs a completion handler. Hence, outer scope will not have children to wait for completion and will terminate immediately.