Remove unused code to ignore runtime stack frames #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtime.CallerFrames is currently ignoring the last frame, which is always runtime.main (for the main goroutine) and runtime.goexit (for additional goroutines). Since the main goroutine will include the user's main function, this is noise that doesn't add much value. We had special logic to ignore these runtime frames specifically, but it's not required since it's only ever the very last stack frame and we already ignore the last frame.
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
=========================================
+ Coverage 96.94% 97.2% +0.25%
=========================================
Files 37 37
Lines 2225 2253 +28
=========================================
+ Hits 2157 2190 +33
+ Misses 59 56 -3
+ Partials 9 7 -2
Continue to review full report at Codecov.
|
billf
approved these changes
Aug 17, 2017
akshayjshah
approved these changes
Aug 18, 2017
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime.CallerFramesis currently ignoring the last frame, which isalways
runtime.main(for the main goroutine) andruntime.goexit(foradditional goroutines). Since the main goroutine will include the user's
main function, this is noise that doesn't add much value.
We had special logic to ignore these runtime frames specifically, but
it's not required since it's only ever the very last stack frame and we
already ignore the last frame.