-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make caller serialization configurable #327
Conversation
@skipor, thanks for your PR! By analyzing the history of the files in this pull request, we identified @akshayjshah, @peter-edge and @imkira to be potential reviewers. |
I don't think copying someone else's code out to your own repo is a nice thing to do, also you just copied the license so this doesn't change anything. We were thinking of using Chris Hines' code in #311. This code somewhat duplicates that effort as well. |
9bce468
to
0b3171a
Compare
0b3171a
to
a81a860
Compare
Does this PR have a chance to land before 1.0? |
@peter-edge, @akshayjshah need I fix something, or your will handle this PR yourself? |
There's certainly a chance that this can land before 1.0; it's not a breaking change, so we can also land it after 1.0 if necessary. @skipor we can take it from here - I just need to spend the time to review it carefully :) |
a81a860
to
5bb2590
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just going to push some small cleanups.
5bb2590
to
f785f2a
Compare
CallerEncoder similar to other encoders for complex types. It allows to configure caller presentation in log.
$GOPATH trim logic based on
go-stack/stack
which is under Apache license, so can't be put in repo. So required logic have been moved to another repo (skipor/goenv), and exported as third party.That decision is doubtful, so fell free to propose something better.
WARN: skipor/goenv is not pinned in glide.lock. I don't know how to do this without updating and keeping glide.lock hash valid.