Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix lint issues, makefile target #1443

Merged
merged 1 commit into from
May 30, 2024
Merged

ci: Fix lint issues, makefile target #1443

merged 1 commit into from
May 30, 2024

Conversation

mway
Copy link
Member

@mway mway commented May 30, 2024

Noticed that there were a handful of lint issues, all errcheck things. This PR:

  • Adds underscores to clarify error discarding
  • Updates the make golangci-lint target to use ./..., as e.g. there are no exp/*.go files

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (4425037) to head (4890655).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1443   +/-   ##
=======================================
  Coverage   98.69%   98.70%           
=======================================
  Files          53       53           
  Lines        2996     3014   +18     
=======================================
+ Hits         2957     2975   +18     
  Misses         31       31           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mway mway requested a review from sywhang May 30, 2024 13:31
@mway mway merged commit b2cb7a8 into master May 30, 2024
8 checks passed
@mway mway deleted the mway/ci/lint branch May 30, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants