Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapEncoder.AddByteString should add the value as a string #503

Closed
prashantv opened this issue Sep 22, 2017 · 1 comment
Closed

MapEncoder.AddByteString should add the value as a string #503

prashantv opened this issue Sep 22, 2017 · 1 comment
Assignees
@prashantv

Comments

@prashantv
Copy link
Collaborator

The AddByteString was added as a performance optimization to avoid allocations from []byte to string when logging, when the final value is a string:
#366

Currently the MapEncoder stores this as a []byte, which is incorrect. We should store the value as a string
@prashantv prashantv self-assigned this Sep 22, 2017
@akshayjshah
Copy link
Contributor

Ah, good point.

@prashantv prashantv mentioned this issue Sep 22, 2017
Merged
prashantv added a commit that referenced this issue Sep 25, 2017
@prashantv
MapEncoder: Store strings in map when AddByteString is used (#504)
35aad58 
Fixes #503.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prashantv prashantv

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prashantv @akshayjshah