CI: Fix Windows FIND warning #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 24 24
Lines 941 941
=======================================
Hits 934 934
Misses 6 6
Partials 1 1 Continue to review full report at Codecov.
|
287da12
to
2f9db73
Compare
Currently, CI on Windows reports the following error: ``` FIND: Parameter format not correct ``` This is because of our eager evaluation of the `find` commands above that are not quite valid on Windows. Replace one unnecessary `find` command, and turn the other to lazy evaluation. With `=` instead of `:=`, that `find` will be evaluated in the `make lint` task only, which doesn't run on Windows.
2f9db73
to
6d65b91
Compare
sywhang
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CI on Windows reports the following error:
This is because of our eager evaluation of the
findcommands abovethat are not quite valid on Windows.
Replace one unnecessary
findcommand,and turn the other to lazy evaluation.
With
=instead of:=, thatfindwill be evaluated in themake linttask only, which doesn't run on Windows.