Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.14.0 #723

Merged
merged 7 commits into from
Aug 12, 2021
Merged

Release 1.14.0 #723

merged 7 commits into from
Aug 12, 2021

Conversation

shirchen
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #723 (8bb4ca1) into master (071f468) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #723   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files          24       24           
  Lines         771      771           
=======================================
  Hits          758      758           
  Misses         10       10           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071f468...8bb4ca1. Read the comment docs.

@shirchen
Copy link
Contributor Author

@abhinav What do you of releasing structured logging which currently does not have an API to modify the field names (eg some customer may want fields to be emitted as msg vs message) and then following up with an API in a future release. I think adding structured logging does move the needle forward and will give us some user feedback.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated
- Standardizing event message tenses and adding new ones: Stopped, Invoking, etc.

### Fixed
- Fixing a race condition in a unit test.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not user facing)

CHANGELOG.md Outdated
- `fxtest.Lifecycle` now logs to the provided `testing.TB` instead of stderr.
- `fx.In` and `fx.Out` are now type aliases instead of structs.
- Standardizing event message tenses and adding new ones: Stopped, Invoking, etc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not a change because never released)

Copy link
Collaborator

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do this!

Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaay

@shirchen shirchen merged commit af8dcf3 into uber-go:master Aug 12, 2021
sywhang pushed a commit to sywhang/fx that referenced this pull request Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants