Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing release 1.7.0 #227

Merged
merged 2 commits into from
Jan 4, 2019
Merged

Preparing release 1.7.0 #227

merged 2 commits into from
Jan 4, 2019

Conversation

vyshah
Copy link
Contributor

@vyshah vyshah commented Nov 15, 2018

No description provided.

@vyshah vyshah requested a review from abhinav November 15, 2018 22:50
@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

Merging #227 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #227   +/-   ##
======================================
  Coverage    98.4%   98.4%           
======================================
  Files           9       9           
  Lines        1130    1130           
======================================
  Hits         1112    1112           
  Misses         13      13           
  Partials        5       5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ea31e...ba7069a. Read the comment docs.

Copy link
Collaborator

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get at least one other person to sign off. @akshayjshah @glibsm

@glibsm
Copy link
Collaborator

glibsm commented Dec 28, 2018

I this held up by anything else?

@abhinav
Copy link
Collaborator

abhinav commented Dec 28, 2018

No, this isn't held up. We just decided not to release it until after NYE.

@glibsm
Copy link
Collaborator

glibsm commented Dec 28, 2018

No, this isn't held up. We just decided not to release it until after NYE.

So... to summarize... yes.
It's held up by time =]

@abhinav abhinav merged commit 8a5e175 into master Jan 4, 2019
@abhinav abhinav deleted the vs-release branch January 4, 2019 17:42
@abhinav
Copy link
Collaborator

abhinav commented Jan 4, 2019

Derp, wrong release date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants