-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to prune non-error entries out of the graph #218
Conversation
0b2091b
to
12eb650
Compare
a6f44ff
to
eb47e5e
Compare
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
=========================================
- Coverage 98.93% 98.64% -0.3%
=========================================
Files 9 9
Lines 1032 1104 +72
=========================================
+ Hits 1021 1089 +68
- Misses 9 11 +2
- Partials 2 4 +2
Continue to review full report at Codecov.
|
be8cb66
to
bc3c7e0
Compare
b2aad24
to
9faa55f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Offline discussion, maybe something like this:
type ResultConsumer interface {
// Asks the consumer to delete the reference to this Result.
deleteResult(*Result)
}
// Ctor and Group implement ResultConsumer.
type Result struct {
// ...
Consumers []ResultConsumer
}
4332f45
to
a0984fc
Compare
a0984fc
to
1b6ad09
Compare
Added a Prune method to remove entries from the graph that do not contain any failing results. Graph nodes that are not root or transitive failures do not help the user debug and make it more difficult to debug by cluttering the graph. Orient the graph left to right for graph readability
1b6ad09
to
c23bc0c
Compare
No description provided.