tests: Better use of assertErrorMatches #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for DeferAcyclicVerification was making N separate calls to assertErrorMatches which doesn't verify that the different components of the error messages appear in the correct order. This switches to "correct" usage so that we're verifying that the correct types appear in the error messages at the correct spot. In this case, we want "C depends on B depends on A depends on C".
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
=======================================
Coverage 98.93% 98.93%
=======================================
Files 9 9
Lines 1032 1032
=======================================
Hits 1021 1021
Misses 9 9
Partials 2 2Continue to review full report at Codecov.
|
glibsm
approved these changes
Sep 19, 2018
| @@ -1626,14 +1626,9 @@ func TestProvideCycleFails(t *testing.T) { | |||
| assert.True(t, IsCycleDetected(err)) | |||
| assertErrorMatches(t, err, | |||
| `cycle detected in dependency graph:`, | |||
| ) | |||
| assertErrorMatches(t, err, | |||
| `\*dig.C provided by "go.uber.org/dig".TestProvideCycleFails.\S+ \(\S+\)`, | |||
There was a problem hiding this comment.
(\S+:\D+\) for file:line is better than just (<whatever>) but that's not in the scope of this PR
There was a problem hiding this comment.
I didn't want to be overly specific there in case we decide to add more information in the parens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for DeferAcyclicVerification was making N separate calls to
assertErrorMatches which doesn't verify that the different components of
the error messages appear in the correct order.
This switches to "correct" usage so that we're verifying that the
correct types appear in the error messages at the correct spot. In this
case, we want "C depends on B depends on A depends on C".