Cope with numpy-1.24 type symbol deprecations #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dammit, a typo in the commit message - I hate that...... |
|
Should we also be coping with int64/uint64 (not sure why we didn't do this earlier). And the int8 support coming to GDAL soon (https://gdal.org/development/rfc/rfc87_signed_int8.html).... |
You can edit the title of this PR at least. When you do a squash and merge the originally commit message will be lost anyway. |
neilflood
changed the title
|
I think we do already cope with int64/uint64. There is a little extra couple of lines to add to that list, if gdalconst has GDT_Int64. Thanks, edited the title, at least :-) |
|
By the way, I also tested these changes under numpy-1.23, and it works fine there, too. |
gillins
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now passes standard tests under numpy-1.24.0.