fix: use localhost to avoid config leak attacks

tzmax · Nov 7, 2023 · 1365ff3 · 1365ff3
1 parent 8ab90e9
commit 1365ff3
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 4 deletions.
diff --git a/GCDWebServer b/GCDWebServer
diff --git a/V2RayX/AppDelegate.h b/V2RayX/AppDelegate.h
@@ -45,6 +45,7 @@ int runCommandLine(NSString* launchPath, NSArray* arguments);
 }
 
 @property NSString* logDirPath;
+@property NSString* webServerUuidString;
 
 @property BOOL proxyState;
 @property ProxyMode proxyMode;

diff --git a/V2RayX/AppDelegate.m b/V2RayX/AppDelegate.m
@@ -128,9 +128,20 @@ - (void)applicationDidFinishLaunching:(NSNotification *)aNotification {
  return [GCDWebServerDataResponse responseWithData:[weakSelf pacData] contentType:@"application/x-ns-proxy-autoconfig"];
  }];
  [webServer addHandlerForMethod:@"GET" path:@"/config.json" requestClass:[GCDWebServerRequest class] processBlock:^GCDWebServerResponse * _Nullable(__kindof GCDWebServerRequest * _Nonnull request) {
- return [GCDWebServerDataResponse responseWithData:[weakSelf v2rayJSONconfig] contentType:@"application/json"];
+ // check uuid
+ NSString *uuid = request.query[@"u"];
+ if(uuid != NULL) {
+ uuid = [uuid uppercaseString];
+ if([uuid isEqualToString:weakSelf.webServerUuidString]) {
+ return [GCDWebServerDataResponse responseWithData:[weakSelf v2rayJSONconfig] contentType:@"application/json"];
+ }
+ }
+ return [GCDWebServerResponse responseWithStatusCode:404];
  }];
- [webServer startWithPort:webServerPort bonjourName:nil];
+
+ // only bind localhost
+ NSDictionary *options = @{ @"Port": @webServerPort, @"BindToLocalhost": @YES };
+ [webServer startWithOptions:options error:nil];
 
 
  [self checkUpgrade:self];
@@ -1110,7 +1121,11 @@ - (IBAction)copyExportCmd:(id)sender {
 }
 
 - (IBAction)viewConfigJson:(NSMenuItem *)sender {
- [[NSWorkspace sharedWorkspace] openURL:[NSURL URLWithString:[NSString stringWithFormat:@"http:https://127.0.0.1:%d/config.json", webServerPort]]];
+ if(_webServerUuidString == nil) {
+ NSUUID *uuid = [NSUUID UUID];
+ _webServerUuidString = [uuid UUIDString];
+ }
+ [[NSWorkspace sharedWorkspace] openURL:[NSURL URLWithString:[NSString stringWithFormat:@"http:https://127.0.0.1:%d/config.json?u=%@", webServerPort, _webServerUuidString]]];
 }