Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit Node version support #1478

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

textbook
Copy link
Contributor

parseArgs was added to node:util in v16.17/v8.3. Given the CI workflow is only testing 18.x and 20.x, >=18.3 seemed appropriate.

I also considered adding 18.3 explicitly to the node-version list in CI. However, note that the tests rely on the --import flag, new in v18.181, so support for v18.3 can't be automatically validated. It would be possible to add some higher-level tests that start and make requests to lib/bin.js (I tried this out in v18.3, basically copied src/app.test.ts and made it JS, and it works fine).

1 Also it won't run in 18.18.2, the imports in the tests error out with TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts", but everything's fine as of 18.19.0.

@typicode
Copy link
Owner

Thank you!

@typicode typicode merged commit 0812ef2 into typicode:main Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants