Add explicit Node version support #1478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parseArgs
was added tonode:util
in v16.17/v8.3. Given the CI workflow is only testing 18.x and 20.x,>=18.3
seemed appropriate.I also considered adding
18.3
explicitly to thenode-version
list in CI. However, note that the tests rely on the--import
flag, new in v18.181, so support for v18.3 can't be automatically validated. It would be possible to add some higher-level tests that start and make requests tolib/bin.js
(I tried this out in v18.3, basically copiedsrc/app.test.ts
and made it JS, and it works fine).1 Also it won't run in 18.18.2, the imports in the tests error out with
TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts"
, but everything's fine as of 18.19.0.