Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note about renaming #6696

Merged
merged 8 commits into from
Jul 11, 2024
Merged

Conversation

mernst
Copy link
Member

@mernst mernst commented Jul 6, 2024

No description provided.

@mernst
Copy link
Member Author

mernst commented Jul 6, 2024

@kelloggm Do you understand the reason for a test failure with a class renaming?

@kelloggm
Copy link
Contributor

kelloggm commented Jul 9, 2024

Do you understand the reason for a test failure with a class renaming?

@mernst No, I do not. The error in the log is caused by using an ajava file that was generated from the test input before it was renamed. However, there is no such .ajava file checked-in (which was my first suspicion).

Is it possible that the CI machines have corrupted gradle caches? That's the only plausible thing that I can think of that might cause a failure like this one.

Have you tried to rerun CI or to reproduce the problem locally? It's possible that it's transient, if it's related to the gradle cache.

@mernst
Copy link
Member Author

mernst commented Jul 9, 2024

@kelloggm I have re-run CI many times, and I have also reproduced the problem locally. I'm befuddled.

@kelloggm
Copy link
Contributor

@mernst I made the change in the location that your comment indicated again myself and the tests passed locally. I'm running CI now to see whether they also pass in CI.

I notice that the commit history includes some other renamings besides the specific one that you pointed me to in this PR. Would you like me to look into any of those, too?

@mernst
Copy link
Member Author

mernst commented Jul 10, 2024

@kelloggm Thanks! I tried quite a number of things. If this one you did works, I'm happy.

@kelloggm kelloggm merged commit 7a4edd9 into typetools:master Jul 11, 2024
28 checks passed
@kelloggm kelloggm deleted the varargstest-methodref-rename-2 branch July 11, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants