Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @SideEffectsOnly annotation #5582

Draft
wants to merge 174 commits into
base: master
Choose a base branch
from
Draft

Add @SideEffectsOnly annotation #5582

Changes from 1 commit
Commits
Show all changes
174 commits
Select commit Hold shift + click to select a range
427c55a
temp commit
t-rasmud Dec 3, 2020
0ad09bb
side effects only checker
t-rasmud Dec 3, 2020
15ca2db
side effects only for this and field values
t-rasmud Dec 4, 2020
2857929
more tests
t-rasmud Dec 4, 2020
21dc0a4
add null checks
t-rasmud Dec 4, 2020
ef59d5e
side effects only javadoc
t-rasmud Dec 4, 2020
40fdfd8
purity suggestions test
t-rasmud Dec 4, 2020
ac6d8ca
nullness check
t-rasmud Dec 4, 2020
df56c0d
javadoc
t-rasmud Dec 4, 2020
48d2d42
remove sideeffectsonly from purity
t-rasmud Dec 5, 2020
595de2c
remove side_effects_only from purity kinds
t-rasmud Dec 5, 2020
9347508
Merge branch 'master' of github.com:t-rasmud/checker-framework into s…
t-rasmud Dec 6, 2020
1459a9c
remove unnecessary
t-rasmud Dec 6, 2020
39edb6d
add documentation
t-rasmud Dec 6, 2020
b3ecb7e
documentation for side effects only
t-rasmud Dec 6, 2020
7300132
fix formatting
t-rasmud Dec 6, 2020
8c3a428
fix side effects only for receiver
t-rasmud Dec 8, 2020
c34dd98
checher-qual after merging with master
t-rasmud Feb 16, 2021
1c9d4ad
remove unrelated
t-rasmud Feb 16, 2021
dcc0390
Merge branch 'master' of github.com:t-rasmud/checker-framework into s…
t-rasmud Feb 17, 2021
a2dd514
refactor qual
t-rasmud Feb 17, 2021
34c456b
Merge github.com:typetools/checker-framework
t-rasmud Feb 23, 2021
5eb932a
Merge github.com:typetools/checker-framework
t-rasmud Feb 23, 2021
5fd464f
Merge branch 'master' of github.com:t-rasmud/checker-framework into s…
t-rasmud Mar 2, 2021
a0442b4
remove unrelated test file
t-rasmud Mar 2, 2021
ce77c26
documenting toy checker
t-rasmud Mar 2, 2021
171090d
fix documentation and refactoring
t-rasmud Mar 2, 2021
6877a37
fix SideEffectsOnly documentation
t-rasmud Mar 2, 2021
8a04d7f
improves documentation for SideEffectsOnly
t-rasmud Mar 2, 2021
245984b
more documentation for SideEffectsOnly
t-rasmud Mar 2, 2021
d7a6c6a
Merge github.com:typetools/checker-framework
t-rasmud Mar 4, 2021
837128d
Merge branch 'master' of github.com:t-rasmud/checker-framework into s…
t-rasmud Mar 4, 2021
ec10c52
addressing review
t-rasmud Mar 4, 2021
201d09b
addressing review: entryset() to keyset()
t-rasmud Mar 4, 2021
39f0044
give meaningful qualifier names
t-rasmud Mar 4, 2021
835712a
address review
t-rasmud Mar 4, 2021
9bbe372
JavaExpression instead of String and clean-up
t-rasmud Mar 5, 2021
3e0fbe7
test case: change parameter names
t-rasmud Mar 5, 2021
5f03c88
fix documentation
t-rasmud Mar 5, 2021
d1dc0cb
Merge github.com:typetools/checker-framework
t-rasmud Mar 5, 2021
9344756
Merge branch 'master' of github.com:t-rasmud/checker-framework into s…
t-rasmud Mar 5, 2021
5afaf07
Merge branch 'master' of github.com:t-rasmud/checker-framework into s…
t-rasmud Mar 5, 2021
237e037
fix checker-qual
t-rasmud Mar 5, 2021
f93a6dc
checker-qual signedness fix
t-rasmud Mar 5, 2021
4590c3d
Merge ../checker-framework-branch-master into side-effects-only
mernst Mar 6, 2021
810a45a
fix documentation for SideEffectsOnly
t-rasmud Mar 9, 2021
6c3560e
SideEffectsOnly empty test
t-rasmud Mar 9, 2021
d4d967d
SideEffectsOnly documentation fixes
t-rasmud Mar 9, 2021
9b85e87
Merge branch 'side-effects-only' of github.com:t-rasmud/checker-frame…
mernst Mar 11, 2021
d9cd13d
Merge ../checker-framework-branch-master into side-effects-only
mernst Mar 18, 2021
4712584
Documentation improvements
mernst Mar 18, 2021
9275dee
Tweaks
mernst Mar 18, 2021
3d2caa1
Fix error and test case for SideEffectsOnly field
t-rasmud Mar 22, 2021
9750682
Merge branch 'master' of github.com:t-rasmud/checker-framework into s…
t-rasmud Mar 22, 2021
875f638
SideEffects relationship documentatio
t-rasmud Mar 22, 2021
0541f0f
Merge ../checker-framework-branch-master into side-effects-only
mernst Mar 23, 2021
8ea0e1e
Merge ../checker-framework-branch-master into side-effects-only
mernst Mar 24, 2021
3092354
Undo whitespace change
mernst Mar 24, 2021
4a11c51
Tweak documentation
mernst Mar 24, 2021
bf86930
clean imports
t-rasmud Mar 30, 2021
dee4cd3
report error correctly
t-rasmud Mar 30, 2021
6e5c391
address review comment
t-rasmud Mar 30, 2021
87bd9a7
reintroduce incorrectly deleted code
t-rasmud Mar 30, 2021
cbc6afb
merge with master; check; skip pre-commit
t-rasmud Mar 31, 2021
7e0337c
fix updateForMethodCall after merge
t-rasmud Mar 31, 2021
94176a4
fix imports
t-rasmud Apr 2, 2021
d5c2fea
Merge branch 'master' of github.com:t-rasmud/checker-framework into s…
t-rasmud Apr 3, 2021
a2c749e
fix deprecated method
t-rasmud Apr 6, 2021
0d5d7b4
javadoc fixes
t-rasmud Apr 7, 2021
2abdc8c
test case for empty @SideEffectsOnly
t-rasmud Apr 8, 2021
a8cad8c
temp commit: experimenting
t-rasmud Apr 9, 2021
1cc560e
SideEffectsOnly checker: reports error on some assignments
t-rasmud Apr 12, 2021
b446e3c
merge with master
t-rasmud May 19, 2021
8e62d1e
imports refactoring
t-rasmud May 20, 2021
533f1eb
Merge branch 'master' of github.com:t-rasmud/checker-framework into s…
t-rasmud May 31, 2021
7e6f352
Merge branch 'master' of github.com:t-rasmud/checker-framework into s…
t-rasmud Jun 25, 2021
9f19380
merge
t-rasmud Jul 8, 2021
0288bdf
handling method invocations
t-rasmud Jul 11, 2021
e09d7ea
SEOnly checking at method invocations
t-rasmud Jul 14, 2021
42c6748
Merge ../checker-framework-branch-master into side-effects-only
mernst Aug 3, 2021
0e478f5
Merge branch 'side-effects-only' of github.com:t-rasmud/checker-frame…
t-rasmud Aug 9, 2021
72647aa
Merge branch 'master' of github.com:t-rasmud/checker-framework into s…
t-rasmud Aug 9, 2021
f91ac19
fix package name
t-rasmud Aug 9, 2021
fc91585
test case: Check SideEffectsOnly
t-rasmud Aug 12, 2021
4bcbb3b
comments
t-rasmud Aug 15, 2021
ebe7036
Merge branch 'master' of github.com:t-rasmud/checker-framework into s…
t-rasmud Aug 15, 2021
e6a61f5
builds
t-rasmud Aug 23, 2021
990e6e2
Merge branch 'master' of github.com:t-rasmud/checker-framework into s…
t-rasmud Oct 14, 2021
9220596
SideEffectsOnlyAnnoChecker
t-rasmud Oct 14, 2021
fccd5e6
test case fixes
t-rasmud Oct 14, 2021
6d2d9fa
javadoc
t-rasmud Oct 18, 2021
e5c48be
Merge branch 'master' of github.com:t-rasmud/checker-framework into s…
t-rasmud Oct 18, 2021
3c8878c
documentation for -AcheckSideEffectsOnlyAnnotation
t-rasmud Oct 20, 2021
a4439a1
Merge branch 'master' of github.com:t-rasmud/checker-framework into s…
t-rasmud Oct 21, 2021
15b3a08
Documentation tweaks
mernst Oct 21, 2021
8dd7d94
Tweak comment
mernst Oct 27, 2021
1264b07
change method name
t-rasmud Nov 2, 2021
5b0dbc5
fix error message key
t-rasmud Nov 2, 2021
1ecd0fe
checkPurityAnnotations flag checks SideEffectsOnly
t-rasmud Nov 2, 2021
a984534
report error if invoked method not @SideEffectsOnly
t-rasmud Nov 6, 2021
177c221
report error if invoked method not @SideEffectsOnly
t-rasmud Nov 6, 2021
eb71099
adding test case
t-rasmud Nov 8, 2021
a1115c7
fixing javadoc
t-rasmud Nov 8, 2021
30f4258
fixing javadoc
t-rasmud Nov 8, 2021
b630298
testing CheckSideEffectsOnly functionality in Purity Checker
t-rasmud Nov 14, 2021
d1b69c4
minor
t-rasmud Nov 14, 2021
d9e3336
fix
t-rasmud Nov 15, 2021
9632766
Merge branch 'master' of github.com:t-rasmud/checker-framework into s…
t-rasmud Nov 22, 2021
b0a4dd0
Merge ../checker-framework-branch-master into side-effects-only
mernst Jan 5, 2023
2d33f32
Tweaks
mernst Jan 5, 2023
5a1fc70
Merge ../checker-framework-branch-master into side-effects-only
mernst Jan 8, 2023
dfcd7a9
Merge ../checker-framework-branch-master into side-effects-only
mernst Jan 26, 2023
f595e57
Merge ../checker-framework-branch-master into side-effects-only
mernst Jan 26, 2023
58a847e
Assign `body` once
mernst Jan 26, 2023
b35a2d7
Merge branch 'master' into side-effects-only
mernst Jan 26, 2023
b4ed608
Add default constructors as required by JDK 19
mernst Jan 26, 2023
4c2764b
Merge ../checker-framework-branch-master into side-effects-only
mernst Jan 26, 2023
c88351c
Remove unneeded option
mernst Jan 26, 2023
0161dfb
Tweak comments
mernst Jan 26, 2023
8d97f20
Rename
mernst Jan 26, 2023
f639ba2
Add documentation
mernst Jan 26, 2023
1463fff
Rename variable
mernst Jan 26, 2023
67c0e46
Merge branch 'side-effects-only' of github.com:mernst/checker-framewo…
mernst Jan 26, 2023
3b6c532
Merge ../checker-framework-branch-master into side-effects-only
mernst Feb 2, 2023
d74c8a4
Checkpoint
mernst Feb 3, 2023
ca34d95
Merge ../checker-framework-branch-master into side-effects-only
mernst Feb 3, 2023
6c5d10c
Merge branch 'master' into side-effects-only
mernst Feb 3, 2023
9d1f067
Merge ../checker-framework-branch-master into side-effects-only
mernst Feb 20, 2023
8b5e726
Merge branch 'master' into side-effects-only
mernst Mar 14, 2023
0832758
Tweak definition of `@SideEffectsOnly`
mernst Jan 22, 2024
03bca3f
Reduce diffs with upstream
mernst Jan 22, 2024
d52132e
Merge ../checker-framework-branch-master into side-effects-only
mernst Jan 22, 2024
98607fe
Merge ../checker-framework-branch-master into side-effects-only
mernst Apr 1, 2024
275e806
Merge branch 'typetools:master' into side-effects-only
jyoo980 Apr 4, 2024
8c56e18
Issue warning on `@SideEffectsOnly({})`
jyoo980 Apr 5, 2024
cf0f995
Merge branch 'master' into side-effects-only
jyoo980 Apr 5, 2024
31d1b43
Update manual guidance for `@SideEffectsOnly({})`
jyoo980 Apr 5, 2024
3a69228
Merge branch 'side-effects-only' of github.com:mernst/checker-framewo…
jyoo980 Apr 5, 2024
a9fccf6
Add test case for empty `@SideEffectsOnly`
jyoo980 Apr 8, 2024
647c9b9
Merge branch 'master' into side-effects-only
jyoo980 Apr 8, 2024
98c1b5d
Update tests
jyoo980 Apr 8, 2024
ed83772
Merge branch 'master' into side-effects-only
jyoo980 Apr 10, 2024
3afb830
Apply lint
jyoo980 Apr 11, 2024
2f7355b
Refactor `SideEffectsOnlyChecker#visitMethodInvocation` and pass more…
jyoo980 Apr 12, 2024
b2fb30b
Fix failing test
jyoo980 Apr 12, 2024
9f9e005
Make behaviour consistent with manual when `@SideEffectsOnly` appears…
jyoo980 Apr 12, 2024
3bea5d8
Add Javadoc
jyoo980 Apr 12, 2024
7b1f256
Add naive implementation for aliasing
jyoo980 Apr 13, 2024
b7c8187
Improve error message
jyoo980 Apr 13, 2024
73c45c0
Correct Javadoc
jyoo980 Apr 13, 2024
01ff6f8
"Unrefine" fields in abstract store depending on declared side-effects
jyoo980 Apr 14, 2024
4fe3a6e
Update Javadoc
jyoo980 Apr 14, 2024
61909fd
Remove unnecessary print line
jyoo980 Apr 15, 2024
a4f3ec1
Correct logic for field CFStore updates
jyoo980 Apr 15, 2024
7ec0b2f
Update naming
jyoo980 Apr 15, 2024
da51f1b
Merge branch 'master' into side-effects-only
jyoo980 Apr 15, 2024
9f81866
Merge branch 'master' into side-effects-only
jyoo980 Apr 15, 2024
d4230fe
Merge branch 'master' into side-effects-only
jyoo980 Apr 15, 2024
64a6561
Make refinement happen for local variables (THIS BREAKS TESTS)
jyoo980 Apr 16, 2024
d5347bd
Merge branch 'master' into side-effects-only
jyoo980 Apr 17, 2024
e02124d
Merge branch 'master' into side-effects-only
jyoo980 Apr 20, 2024
d55c9d8
Update logic for removing information from method calls
jyoo980 Apr 23, 2024
906c8b5
Merge branch 'master' into side-effects-only
jyoo980 Apr 23, 2024
dcede5d
Merge branch 'master' into side-effects-only
jyoo980 Apr 23, 2024
820002a
Add test case
jyoo980 Apr 23, 2024
090ec33
Avoid CF crash when invalid expression is passed to `@SideEffectsOnly`
jyoo980 Apr 23, 2024
4f46ad4
Merge branch 'master' into side-effects-only
jyoo980 Apr 23, 2024
5911bfd
Possible fix to forEach lambda
jyoo980 Apr 24, 2024
44c5020
Merge branch 'side-effects-only' of github.com:mernst/checker-framewo…
jyoo980 Apr 24, 2024
7e9e02c
Clean up test case
jyoo980 Apr 24, 2024
a39c61d
Merge branch 'master' into side-effects-only
jyoo980 Apr 26, 2024
17c0ce6
Removing `sideEffectsUnrefineAliases` flag
jyoo980 Apr 27, 2024
e7cf745
Merge branch 'master' into side-effects-only
jyoo980 Apr 29, 2024
8966a5d
Merge ../checker-framework-branch-master into side-effects-only
mernst Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' of github.com:t-rasmud/checker-framework into s… 
…ide-effects-only
  • Loading branch information
@t-rasmud
t-rasmud committed Dec 6, 2020
commit 9347508334bca0f0712262af5f85a633f4aac2a2

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.