Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove myself from maintainers list #444

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

jeremyrsmith
Copy link
Contributor

I want to say that:

  1. I think this project is awesome! It does a lot of good for type-conscious users at the intersection of Spark and FP. πŸ™
  2. I love being credited as a maintainer! I'm sure it's a huge source of credibility for me πŸ˜€
  3. I do care about this project and I want to see it thrive!

However,

  1. I don't think I've ever made a PR to frameless that ended up getting merged (ironically, I hope this one will πŸ˜† ). Listing me as a maintainer is mostly a historical artifact of myself and (I think) @OlivierBlanvillain being at the same place at the same time w.r.t. having the idea of shapeless+spark, googling it, finding that @adelbertc had already started on it, and offering to work on it. I'm grateful for the direction it's gone in since then, but I don't deserve any credit for it!
  2. I think that crediting me as a maintainer, when I've essentially never done any maintenance on what frameless currently is, is unfair to the real maintainers and a discredit to them.
  3. As much as I would like to, I don't actually get to use frameless in projects I currently work on, so not only do I not actually maintain it but I don't even regularly use it. So it's doubly unfair that I'm listed as a maintainer when there are tons of folks who use & contribute to it (and here I am doing neither).

Someday I hope to be a more active user and if that happens I'll be thrilled to be a contributor as well! But I think it's only fair that I make this change – you're all much too polite to do it I assume – and I should have done it years ago (but I just noticed that I'm still listed).

I want to say that:

1. I think this project is awesome! It does a lot of good for type-conscious users at the intersection of Spark and FP. πŸ™ 
2. I love being credited as a maintainer! I'm sure it's a huge source of credibility for me πŸ˜€ 
3. I do care about this project and I want to see it thrive!

However,

1. I don't think I've ever made a PR to frameless that ended up getting merged (ironically, I hope this one will πŸ˜† ). Listing me as a maintainer is mostly a historical artifact of myself and (I think) @OlivierBlanvillain being at the same place at the same time w.r.t. having the idea of shapeless+spark, googling it, finding that @adelbertc had already started on it, and offering to work on it. I'm grateful for the direction it's gone in since then, but I don't deserve any credit for it!
2. I think that crediting me as a maintainer, when I've essentially never done any maintenance on what frameless currently is, is unfair to the _real_ maintainers and a discredit to them.
3. As much as I would like to, I don't actually get to use frameless in projects I currently work on, so not only do I not actually maintain it but I don't even regularly use it. So it's doubly unfair that I'm listed as a maintainer when there are tons of folks who use & contribute to it (and here I am doing neither).

Someday I hope to be a more active user and if that happens I'll be thrilled to be a contributor as well! But I think it's only fair that I make this change – you're all much too polite to do it I assume – and I should have done it years ago (but I just noticed that I'm still listed).
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2020

Codecov Report

Merging #444 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #444   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files          60       60           
  Lines        1034     1034           
  Branches        4        4           
=======================================
  Hits          995      995           
  Misses         39       39           

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 6f16a49...f55e92c. Read the comment docs.

@imarios
Copy link
Contributor

imarios commented Sep 9, 2020

Hey Jeremy! I would really preferred to see you adding someone rather than removing yourself from the list :D. Maybe showing a smaller list will make more people want to contribute.. So I am ok with merging this.

@jeremyrsmith
Copy link
Contributor Author

Thanks @imarios, I hope someone can be added as well! But the readme should also reflect reality πŸ˜€ so with your blessing I'll merge.

@jeremyrsmith jeremyrsmith merged commit a8bdf2d into master Sep 9, 2020
@jeremyrsmith jeremyrsmith deleted the remove-jeremyrsmith-from-maintainers branch September 9, 2020 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants