Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cos, cosh, sin, sinh, tan, tanh Column functions #265

Merged
merged 2 commits into from
Mar 12, 2018

Conversation

Avasil
Copy link
Contributor

@Avasil Avasil commented Mar 12, 2018

Related to #164

@codecov-io
Copy link

codecov-io commented Mar 12, 2018

Codecov Report

Merging #265 into master will decrease coverage by 1.5%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   96.22%   94.71%   -1.51%     
==========================================
  Files          52       52              
  Lines         926      946      +20     
  Branches       11       11              
==========================================
+ Hits          891      896       +5     
- Misses         35       50      +15
Impacted Files Coverage Δ
...la/frameless/functions/NonAggregateFunctions.scala 100% <100%> (ø) ⬆️
...aset/src/main/scala/frameless/ops/GroupByOps.scala 66.66% <0%> (-31.7%) ⬇️
...c/main/scala/frameless/TypedDatasetForwarded.scala 71.42% <0%> (-2.86%) ⬇️
...main/scala/frameless/ops/RelationalGroupsOps.scala 97.61% <0%> (+18.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be4d63...323f16a. Read the comment docs.

@OlivierBlanvillain
Copy link
Contributor

LGTM, thanks!

@OlivierBlanvillain OlivierBlanvillain merged commit 8dc73e7 into typelevel:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants