Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #167: bump Spark version to 2.2.0 #176

Merged
merged 2 commits into from
Sep 16, 2017

Conversation

OlivierBlanvillain
Copy link
Contributor

No description provided.

@OlivierBlanvillain
Copy link
Contributor Author

@atamborrino It looks like your recently added test breaks with Spark 2.2.0 (I see that you have a 2.1.x specific workaround, would removing that be enough?). I gave you push permissions to this branch if you want to fix it here

@typelevel typelevel deleted a comment from codecov-io Sep 16, 2017
@OlivierBlanvillain
Copy link
Contributor Author

Hmm it might be independent from 2.2, I got another failure due to this VectorUDT test on the joins PR: https://travis-ci.org/typelevel/frameless/builds/276202750

@atamborrino
Copy link
Contributor

atamborrino commented Sep 16, 2017

From https://travis-ci.org/OlivierBlanvillain/frameless/builds/276100054?utm_source=email&utm_medium=notification it looks like Scalacheck generator fails to generate sufficient valid cases for the conditional property (trainingData.numRows >= 2 && trainingData.numCols >= 1) ==>.
I will create a specific generator for non-empty matrix to avoid this case.

@codecov-io
Copy link

codecov-io commented Sep 16, 2017

Codecov Report

Merging #176 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #176   +/-   ##
=====================================
  Coverage      94%    94%           
=====================================
  Files          31     31           
  Lines         667    667           
  Branches        9     13    +4     
=====================================
  Hits          627    627           
  Misses         40     40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c04b3f...e47ae89. Read the comment docs.

@atamborrino
Copy link
Contributor

atamborrino commented Sep 16, 2017

@OlivierBlanvillain fixed. My matrix generator was incorrect. Should be ok now. I also adapted the test for Spark ML 2.2.0.

@OlivierBlanvillain
Copy link
Contributor Author

Thanks for the fix, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants