Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Future instances to implicit scope #3572

Merged
merged 2 commits into from
Aug 19, 2020

Conversation

travisbrown
Copy link
Contributor

See discussion here. I've not built or run tests locally yet but I think it should work.

@codecov-commenter
Copy link

Codecov Report

Merging #3572 into master will decrease coverage by 0.02%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #3572      +/-   ##
==========================================
- Coverage   91.33%   91.30%   -0.03%     
==========================================
  Files         386      386              
  Lines        8612     8618       +6     
  Branches      265      262       -3     
==========================================
+ Hits         7866     7869       +3     
- Misses        746      749       +3     

@barambani
Copy link
Contributor

This should also resolve this #3536. Adding it for reference.

@barambani
Copy link
Contributor

We could remove FutureInstances from here

class FutureTests extends CatsSuite with FutureInstances {
and the import from here
import cats.instances.future._
now. Or you would prefer keep testing the instances through them ? Happy to go on either way 👍 .

Copy link
Contributor

@barambani barambani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly me :). The test changes are already in.
Reminder to self: never look at prs from the phone.

@cb372
Copy link
Contributor

cb372 commented Aug 19, 2020

Once this is merged, it would be handy to have another RC release so I can bump the dependency in scalafix/build.sbt on #3566

@travisbrown
Copy link
Contributor Author

Yes, I'm traveling at the moment but could probably publish an RC tonight if this gets merged before then.

@LukaJCB LukaJCB merged commit 99c2aef into typelevel:master Aug 19, 2020
@cb372
Copy link
Contributor

cb372 commented Aug 19, 2020

@travisbrown Don't worry about it, I didn't realise we were publishing snapshots to Sonatype. I was able to use a snapshot. Enjoy your holiday!

@travisbrown travisbrown added this to the 2.2.0-RC4 milestone Aug 20, 2020
@travisbrown travisbrown deleted the topic/future-instances branch August 21, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants