Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add State.pure #352

Merged
merged 3 commits into from
Jun 22, 2015
Merged

Add State.pure #352

merged 3 commits into from
Jun 22, 2015

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Jun 20, 2015

No description provided.

@codecov-io
Copy link

Current coverage is 60.06%

Merging #352 into master will change coverage by +0.02% by d4c90d0

Coverage Diff

@@            master    #352   diff @@
======================================
  Files          132     132       
  Stmts         1599    1600     +1
  Branches        25      25       
  Methods          0       0       
======================================
+ Hit            960     961     +1
  Partial          0       0       
  Missed         639     639       

Powered by Codecov

@ceedubs
Copy link
Contributor Author

ceedubs commented Jun 20, 2015

Oops. I suppose I shouldn't decrease code coverage. Is there a meaningful test for this that isn't just a duplication of the implementation or an existing monad law?

@non
Copy link
Contributor

non commented Jun 20, 2015

I'm not sure. I guess my feeling is that you should just arrange to have it called somehow. Even just confirming that State.pure[S, A](...) and StateT.pure[Trampoline, S, A](...) are equivalent would be enough.

@ceedubs
Copy link
Contributor Author

ceedubs commented Jun 20, 2015

@non good idea. I added a test that State.pure and StateT.pure are consistent.

@ceedubs
Copy link
Contributor Author

ceedubs commented Jun 22, 2015

This is ready for review.

@non
Copy link
Contributor

non commented Jun 22, 2015

👍

1 similar comment
@julien-truffaut
Copy link
Contributor

👍

julien-truffaut added a commit that referenced this pull request Jun 22, 2015
@julien-truffaut julien-truffaut merged commit a501cfc into typelevel:master Jun 22, 2015
@ceedubs ceedubs deleted the state-pure branch November 15, 2015 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants