Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a link in the documentation for Traverse #3383

Merged
merged 3 commits into from
Apr 14, 2020
Merged

Fix a link in the documentation for Traverse #3383

merged 3 commits into from
Apr 14, 2020

Conversation

justinhj
Copy link
Contributor

@justinhj justinhj commented Apr 2, 2020

Thank you for contributing to Cats!

This is a kind reminder to run sbt +prePR and commit the changed files, if any, before submitting.

@justinhj
Copy link
Contributor Author

justinhj commented Apr 2, 2020

BTW I had to move into the folder cats/docs/target/scala-2.12/resource_managed/main/jekyll to test the site. The contributor docs say docs/target/site but that generated errors for when running Jekyll. Not sure if I'm doing something wrong.

LukaJCB
LukaJCB approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! and sorry for the delay!

@LukaJCB LukaJCB merged commit a46aca6 into typelevel:master Apr 14, 2020
@travisbrown travisbrown added this to the 2.2.0-M2 milestone May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diesalbla diesalbla diesalbla approved these changes

@LukaJCB LukaJCB LukaJCB approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
2.2.0-M2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinhj @diesalbla @LukaJCB @travisbrown