Tests for Validated. #329
Merged
Tests for Validated. #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure failures are combined in order. This required a bugfix. Also test filter and fromTryCatch since these aren't covered by a typeclass instance and are complex enough to need comments. Traverse laws are added in the separate PR for #224.
Closed
|
Looks good to me. 👍 |
|
|
||
| test("ap2 combines failures in order") { | ||
| val plus = (_: Int) + (_: Int) | ||
| assert(Validated.validatedInstances[String].ap2(Invalid("1"), Invalid("2"))(Valid(plus)) == Invalid("12")) |
There was a problem hiding this comment.
Shall we use Applicative[Validated[String, ?]] instead of Validated.validatedInstances[String]?
The latter one is subject to change if we rename the instance
|
minor comments, otherwise it looks very good |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure failures are combined in order. This required a bugfix.
Also test filter and fromTryCatch since these aren't covered by a typeclass instance and are complex enough to need comments.
Traverse laws are added in the separate PR for #224.