#2429 Replace all usage of the list Monoid in the docs with the chain Monoid #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please comment if further changes should be included in the pull request. |
Codecov Report
@@ Coverage Diff @@
## master #2460 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 357 357
Lines 6516 6516
Branches 288 288
=======================================
Hits 6216 6216
Misses 300 300Continue to review full report at Codecov.
|
LukaJCB
reviewed
Sep 4, 2018
|
|
||
| val left: IorNel[String, Int] = Ior.leftNel("Error") | ||
| val left: IorNec[String, Int] = Ior.fromEither("Error".leftNec[Int]) |
There was a problem hiding this comment.
Seems I missed the convenience function here, we should add an Issue for that too. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace
NonEmptyListwithNonEmptyChaininIorandIorTdocsfixes Replace all usage of the list Monoid in the docs with the chain Monoid #2429