Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bin compat goal #1897

Merged
merged 4 commits into from
Sep 8, 2017
Merged

add bin compat goal #1897

merged 4 commits into from
Sep 8, 2017

Conversation

kailuowang
Copy link
Contributor

fixes #1233

@codecov-io
Copy link

codecov-io commented Sep 7, 2017 •
edited
Loading

Codecov Report

Merging #1897 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1897   +/-   ##
======================================
  Coverage    95.2%   95.2%           
======================================
  Files         248     248           
  Lines        4379    4379           
  Branches      125     125           
======================================
  Hits         4169    4169           
  Misses        210     210

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f2ecc...c9096c8. Read the comment docs.

sjrd
sjrd reviewed Sep 8, 2017
View reviewed changes
README.md Outdated

After `1.0.0` release, we [decided](https://github.com/typelevel/cats/issues/1233)
to use *MAJOR.MINOR.PATCH* [Semantic Versioning 2.0.0](https://semver.org/)
going forward, which is different from the *EPIC.MAJOR.MINOR* schema commonly in
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EPIC -> EPOCH ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! corrected.

ceedubs
ceedubs approved these changes Sep 8, 2017
View reviewed changes
Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kailuowang!

@kailuowang kailuowang merged commit 99f6683 into master Sep 8, 2017
@kailuowang kailuowang deleted the add-bin-compat-goal branch September 8, 2017 22:03
eed3si9n
eed3si9n reviewed Sep 8, 2017
View reviewed changes
README.md

Any binary breaking changes will require a *MAJOR* version bump, which we will be very
cautious about. We will also consider using `organization` and package name for major
versioning in the future. But that decision is yet to be made.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for this inclusion.

@durban durban mentioned this pull request Sep 12, 2017
Closed
@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd left review comments

@eed3si9n eed3si9n eed3si9n left review comments

@ceedubs ceedubs ceedubs approved these changes

@fthomas fthomas fthomas approved these changes

@johnynek johnynek Awaiting requested review from johnynek

@mpilquist mpilquist Awaiting requested review from mpilquist

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
1.0.0-RC1
Development

Successfully merging this pull request may close these issues.

Document version compatibility goals
6 participants
@kailuowang @codecov-io @fthomas @eed3si9n @sjrd @ceedubs