Allow Lists, Maps, and Records to coexist in a Union #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Lists, Maps, and Records cannot coexist in a Union because the $read method for these can throw TypeErrors rather than returning them. The Immutable.js List constructor will throw a TypeError when attempting to initialize a list with a non-array-type object, exiting the Union while loop prematurely (before it tests against the other types). This PR adds a try/catch around the $read and swallows any TypeErrors that come out of it. Other error types are thrown so they can be caught up the call stack.
|
👍 Good catch. Let's merge after another set of eyes sees it. |
|
Thanks! Let me know if you need me to do anything else to prep it for merging. |
|
Merged and published. Thanks! |
|
Thanks @stutrek ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Lists, Maps, and Records cannot coexist in a Union because the $read method for these can throw TypeErrors rather than returning them. The Immutable.js List constructor will throw a TypeError when attempting to initialize a list with a non-array-type object, exiting the Union while loop prematurely (before it tests against the other types). This PR adds a try/catch around the $read and swallows any TypeErrors that come out of it. Other error types are thrown so they can be caught up the call stack.