Allow TypeError to be stored as value in record with "Any" field type #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Any and add unit tests to verify the fix.
|
👍 good edge case, good tests, good testing of the edge case. Does anyone see any value in a @lukesneeringer you've contributed the most, please give us a review. |
|
Hey, nice. Approved.
We can wait until someone needs it for something. My guess is it will never come up. |
|
Published just now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just noticed in our project that we're storing the result of a whatwg fetch loading error in our typed-immutable records, and the fact that the error is an instance of TypeError was causing things to blow up, even though the field was set to allow typed.Any.
This PR fixes that issue, and adds some unit tests to verify the fix.