Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Record subclasses #26

Merged
merged 1 commit into from
Jul 27, 2016
Merged

Allow Record subclasses #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Allow Record subclasses 
This change allows Record subclasses to satisfy the check for a Record.
  • Loading branch information
@lukesneeringer
lukesneeringer committed Jul 27, 2016
commit 80458a335ad636ad4bbc1c2604cd73a3aa4c9f15
4 changes: 1 addition & 3 deletions src/record.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@ class TypedRecord extends IterableKeyedBase {
[Typed.read](structure) {
const Type = this.constructor

if (structure instanceof Type &&
structure &&
structure.constructor === Type) {
if (structure && structure instanceof Type) {
return structure
}

Expand Down