Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build setup #24

Merged
merged 3 commits into from
Jul 27, 2016
Merged

Build setup #24

merged 3 commits into from
Jul 27, 2016

Conversation

udnisap
Copy link
Contributor

@udnisap udnisap commented Jul 24, 2016

Can the travis.ci integration I requested from the repo owner approved or can you add me to the management group?
We can use ci to test like udnisap#1

@stutrek @davecoates

@stutrek
Copy link
Member

stutrek commented Jul 25, 2016

Awesome. Does this/do you know how to fix the automated tests that used to run on each PR?

@udnisap
Copy link
Contributor Author

udnisap commented Jul 25, 2016

i need permission to add this to repo
I use it in https://github.com/udnisap/debuk and sementic versioning. so npm publish is also automated based on commits

@stutrek
Copy link
Member

stutrek commented Jul 25, 2016

Sorry, I thought write access was enough. You have admin now.

@udnisap
Copy link
Contributor Author

udnisap commented Jul 25, 2016

I think you need to manually approve it. It says
'Access request pending@typed-immutable'

@stutrek
Copy link
Member

stutrek commented Jul 25, 2016

does this need to be configured first? Do we need to merge this and configure it at the same time? https://github.com/typed-immutable/typed-immutable/settings/hooks/4507717

You have admin on this repo, do whatever you need to do. I don't know where to look for the pending request. Do we need to make a typed-immutable group on travis?

@stutrek
Copy link
Member

stutrek commented Jul 27, 2016

@udnisap do you know where the button I need to press is? Is it even on github?

@lukesneeringer
Copy link
Contributor

If you will make me an admin, I will figure it out. I have done this before.

@lukesneeringer
Copy link
Contributor

Actually, I would need to be an owner, turns out. (I am already an admin.)

@stutrek
Copy link
Member

stutrek commented Jul 27, 2016

You're an owner... LMK what it was.

@lukesneeringer
Copy link
Contributor

lukesneeringer commented Jul 27, 2016

Access is granted. It was under "OAuth applications".
I am going to do the rest of this setup.

It will take a few minutes (hours?) for the access to show up in Travis, though. (They cache your organizations.) I will post here when it is done.

@lukesneeringer lukesneeringer merged commit 7b9fd25 into typed-immutable:master Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants