Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ember-maybe-in-element to supress build-time warning #790

Merged
merged 1 commit into from
May 18, 2023

Conversation

pzubar
Copy link
Collaborator

@pzubar pzubar commented May 17, 2023

The current ember-maybe-in-element produces a warning during the build-time. The 2.1.0 version works fine on all the ember-source versions except the lts-3.16 (that throws an error described in that issue) so we cannot use it in order to provide the support for that ember version.

@pzubar pzubar changed the title Bumps ember-maybe-in-element to supress build-time warning Bump ember-maybe-in-element to supress build-time warning May 17, 2023
@tylerturdenpants
Copy link
Owner

Can we drop 3.16? Will @krasnoukhov be able to continue using it?

@pzubar
Copy link
Collaborator Author

pzubar commented May 17, 2023

I don't think we can drop 3.16 (it is still quite popular ) 😞
However, we can go another way and suggest ember-source <3.20 users using the package.json resolutions like that:

    resolutions: {
      'ember-maybe-in-element': '2.0.3'
    } 

P.S. Sadly, the "resolution" hack doesn't work with the ember try scenario for some reason.

@krasnoukhov
Copy link
Collaborator

I think we can merge this as is and also add a note to #774 about a better future solution

@pzubar pzubar merged commit a43a2eb into master May 18, 2023
@pzubar pzubar deleted the supress-ember-maybe-in-element-warnig branch May 18, 2023 08:55
@pzubar pzubar added enhancement dependencies Pull requests that update a dependency file labels May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants