Fix race condition on timeout between shutdown() and Stop() #97

awfm9 · 2017-01-03T16:17:50Z

This PR is shorter than #93 but should do the same thing.
As we are shutting down, there should be no issue using the stopLock for this purpose.
It's also a rebased version that can be merged right away.

coveralls · 2017-01-03T16:20:27Z

Coverage increased (+0.2%) to 67.236% when pulling 22283e9 on awishformore:fix-timeout-race-condition into 4df1190 on tylerb:master.

tylerstillwater · 2017-01-03T16:22:01Z

LGTM thanks!

awfm9 · 2017-01-03T16:28:54Z

Thanks!

Using stop lock in shutdown function to avoid race condition

22283e9

tylerstillwater merged commit d37e108 into tylerstillwater:master Jan 3, 2017

tylerstillwater mentioned this pull request Jan 3, 2017

Fix data race around Timeout in Stop() and shutdown() #93

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix race condition on timeout between shutdown() and Stop() #97

Fix race condition on timeout between shutdown() and Stop() #97

awfm9 commented Jan 3, 2017

coveralls commented Jan 3, 2017 •

edited

Loading

tylerstillwater commented Jan 3, 2017

awfm9 commented Jan 3, 2017

Fix race condition on timeout between shutdown() and Stop() #97

Fix race condition on timeout between shutdown() and Stop() #97

Conversation

awfm9 commented Jan 3, 2017

coveralls commented Jan 3, 2017 • edited Loading

tylerstillwater commented Jan 3, 2017

awfm9 commented Jan 3, 2017

coveralls commented Jan 3, 2017 •

edited

Loading