-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dark theme fixes #7517
Labels
Comments
piorek
added a commit
that referenced
this issue
Jun 13, 2018
piorek
added a commit
that referenced
this issue
Jun 13, 2018
piorek
added a commit
that referenced
this issue
Jun 13, 2018
piorek
added a commit
that referenced
this issue
Jun 13, 2018
piorek
added a commit
that referenced
this issue
Jun 13, 2018
piorek
added a commit
that referenced
this issue
Jun 14, 2018
piorek
added a commit
that referenced
this issue
Jun 14, 2018
piorek
added a commit
that referenced
this issue
Jun 14, 2018
piorek
added a commit
that referenced
this issue
Jun 14, 2018
Also made spark ui start spinner lighter blue in dark theme |
scottdraves
pushed a commit
that referenced
this issue
Jun 14, 2018
* #7517 plot improvements and fixes * #7517 add missing base styles * #7517 wip - remove unnecessary Data grid border - dark style for table tooltip - dark fieldset styles * #7517 change current and selected cell color in table * #7517 fix dark combobox styles * #7517 fix dark combobox styles * #7517 change table selection and border colors * #7517 date picker dark theme * #7517 refactor spark spinner - move styles from View to .scss file * #7517 make spark spinner lighter when in dark theme * #7517 make unique highlighter work when using dark theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
EasyForm
the following components have a white bkg:
also,
Plots
please make the text (title, tick labels, text items, legend) the same brightness as regular body markdown text.
make the plot bkg same as page background (lose a rectangle).
the plot tooltips need dark theme:
![screen shot 2018-06-12 at 3 43 35 pm](https://user-images.githubusercontent.com/963093/41313239-7024b97a-6e57-11e8-93e3-715e51d6c3e1.png)
Table
it should not be there at all if the table is not focused.
![screen shot 2018-06-12 at 11 03 32 pm](https://user-images.githubusercontent.com/963093/41328314-721a7448-6e95-11e8-8b56-c646a6bce747.png)
except stronger/more-contrast especially between even/odd rows.The text was updated successfully, but these errors were encountered: