Fix empty state not being centered #8650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
This PR modifies the ScrollWrapper component's inner container styling to properly center empty states by changing from flex-based to height-based layout.
- Changed
StyledInnerContainerin/packages/twenty-front/src/modules/ui/utilities/scroll/components/ScrollWrapper.tsxfromflex: 1toheight: 100%to fix empty state centering - Potential edge case: Components relying on ScrollWrapper's flex growth behavior may need adjustment
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
26
to
28
| const StyledInnerContainer = styled.div` | ||
| flex: 1; | ||
| height: 100%; | ||
| `; |
There was a problem hiding this comment.
style: Removing flex:1 may prevent container from growing to fill available space in flex layouts. Consider using both flex:1 and height:100% if both behaviors are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix empty state not being centered
Before:
After:
