Set all standard objects soft deletable #7006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
This pull request sets all standard objects as soft deletable by default, removing individual soft delete specifications from entity decorators.
- Modified
StandardObjectFactoryinstandard-object.factory.tsto setisSoftDeletable: trueas default for all standard objects - Removed
softDelete: trueproperty from entity decorators in multiple files, includingcompany.workspace-entity.ts,note.workspace-entity.ts, andperson.workspace-entity.ts - This change ensures consistent soft delete behavior across all standard objects, potentially affecting data management and recovery processes
8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
charlesBochet
approved these changes
Sep 12, 2024
Weiko
added a commit
that referenced
this pull request
Sep 13, 2024
…ldMetadata (#7017) This #7006 introduced a regression. The goal was to set "isSoftDeletable" to all standard objects but it was done at the wrong level, meaning it was setting the boolean correctly but not creating the corresponding fieldMetadata. I took the occasion to update the new graphql query runner to use that boolean and automatically add a filter on soft delete in case it's true. Also adding **IsQueryRunnerTwentyORMEnabled** by default in the seeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.